feat: DockerContainer initializer to accept its private members as kwargs #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderankin
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
=======================================
Coverage ? 85.46%
=======================================
Files ? 12
Lines ? 688
Branches ? 110
=======================================
Hits ? 588
Misses ? 75
Partials ? 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
will rebase tomorrow and then probably will look it over once more and merge |
alexanderankin
force-pushed
the
container_initializer_accept_more_kwargs
branch
from
7160514 to
711ec78
Compare
alexanderankin
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re submitting what is the end result of the iterations in #238 submitted originally by @vikhal.
Simply enabling the initializer of
DockerContainerto accept its private members as kwargs.